Fix dropped bytes when bulk reading from uv streams with oversized bufs #35695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffers
In readbytes!(s::UVStream, buf::AbstractVector{UInt8}, nb), we wrap `buf`
in a PipeBuffer of maxsize nb and swap it in as the main buffer for the
stream `s`. However, when we inform libuv of the size of the buffer,
we instead use the size of the underlying array, which can be larger.
In that case, we probably either drop bytes or override something that
the user did not want overriden.
Keno
added
io
KristofferC
pushed a commit
that referenced
this pull request
May 10, 2020
…ffers (#35695) In readbytes!(s::UVStream, buf::AbstractVector{UInt8}, nb), we wrap `buf` in a PipeBuffer of maxsize nb and swap it in as the main buffer for the stream `s`. However, when we inform libuv of the size of the buffer, we instead use the size of the underlying array, which can be larger. In that case, we probably either drop bytes or override something that the user did not want overriden. (cherry picked from commit 3a84b51)
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In readbytes!(s::UVStream, buf::AbstractVector{UInt8}, nb), we wrap
bufin a PipeBuffer of maxsize nb and swap it in as the main buffer for the
stream
s. However, when we inform libuv of the size of the buffer,we instead use the size of the underlying array, which can be larger.
In that case, we probably either drop bytes or override something that
the user did not want overriden.