Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for sincosd of missing #34930

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Add test for sincosd of missing #34930

merged 1 commit into from
Feb 29, 2020

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Feb 29, 2020

No description provided.

@kshyatt kshyatt added test This change adds or pertains to unit tests maths Mathematical functions labels Feb 29, 2020
@dkarrasch
Copy link
Member

dkarrasch commented Feb 29, 2020 •
edited
Loading

Interesting that this works, since sind(missing) and cosd(missing) individually don't. In fact, it seems to be the only trig.jl function that handles missing. Should this be fixed by defining deg2rad and rad2deg for missing (in a separate PR)?

EDIT: I think the covered line of code here sneaked in in #30134, even though it was kind of rejected in #30129. So I guess we don't want to add missing versions for deg2rad and rad2deg.

@kshyatt kshyatt merged commit b588181 into master Feb 29, 2020
@kshyatt kshyatt deleted the ksh/sincods branch February 29, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarrasch dkarrasch dkarrasch approved these changes

Assignees
No one assigned
Labels
maths Mathematical functions test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kshyatt @dkarrasch