Updated the documentation for Range function #34467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1408,3 +1408,4 @@ print-%: | |||
| # Literal values that are hard to use in Makefiles otherwise: | |||
| COMMA:=, | |||
| SPACE:=$(eval) $(eval) | |||
| USE_BINARYBUILDER_LLVM=0 | |||
StefanKarpinski
requested changes
Jan 21, 2020
dkarrasch
reviewed
Jan 21, 2020
| If `step` and `stop` are provided and `length` is not, the overall range length will be computed | ||
| automatically such that the elements are `step` spaced (a [`StepRange`](@ref)). | ||
| In case the elements are not simple numeric, elements are spaced using (a [`LinRange`](@ref)) | ||
| # Example |
There was a problem hiding this comment.
The last sentence should probably be finished with a period, and also the brackets look strange. Between the main docstring and the # Example header you could also introduce an empty line, though I'm not sure that makes a difference in the end.
Co-Authored-By: Stefan Karpinski <[email protected]>
|
#34475 created a new PR |
|
@kamalojasv181, in the future, please don't create multiple PRs for the same issue. Just update your existing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33798