Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Unicode #33967

Closed
wants to merge 1 commit into from
Closed

Conversation

PallHaraldsson
Copy link
Contributor

No description provided.

@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Nov 27, 2019

It's unclear if #33965 is an error, and this PR needed, should at least not hurt.

@PallHaraldsson
Copy link
Contributor Author

I get errors from two buildbots (but not the others), completely unrelated to to the one line changed (and file downloaded)...

@c42f
Copy link
Member

c42f commented Nov 29, 2019

It appears this is used to get the official unicode name for every character which has an existing tab completion in the REPL to make the list here: https://docs.julialang.org/en/v1/manual/unicode-input/

So while this update can't do any harm (I understand the Unicode Consortium doesn't remove characters?), it also won't have much (any?) effect until the unicode completions in the REPL are also updated to the latest list available from https://github.com/iamcal/emoji-data. It appears the emoji-data repo is used as an unofficial list of short emoji names for the completion strings.

@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Dec 2, 2019

So while this update can't do any harm (I understand the Unicode Consortium doesn't remove characters?)

Right, I didn't notice anything deleted, by diffing I see 57 lines "deleted" but really changed (and 2306 added). Example of both:

< 20BF;BITCOIN SIGN;Sc;0;ET;;;;;N;;;;;
8241d8137
< 23FF;OBSERVER EYE SYMBOL;So;0;ON;;;;;N;;;;;
9637c9533
< 29A1;SPHERICAL ANGLE OPENING UP;Sm;0;ON;;;;;N;;;;;
---
> 29A1;SPHERICAL ANGLE OPENING UP;Sm;0;ON;;;;;Y;;;;;

@JeffBezanson JeffBezanson added the unicode Related to unicode characters and encodings label Dec 3, 2019
@PallHaraldsson PallHaraldsson deleted the patch-27 branch March 31, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unicode Related to unicode characters and encodings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants