some small gc optimizations #33828
Merged
some small gc optimizations #33828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
approved these changes
Nov 12, 2019
yuyichao
reviewed
Nov 12, 2019
| // TODO: verify that nargs <= nf (currently handled by front-end) | ||
| for (size_t i = 0; i < nargs; i++) { | ||
| const jl_cgval_t &rhs = argv[i]; | ||
| if (jl_field_isptr(sty, i) && !rhs.isboxed) |
There was a problem hiding this comment.
What was the condition that required this previously? It was pre linear IR so I won't be surprised if it isn't needed anymore but I do remember it was quite non-obvious so I want to make sure it's not needed anymore...
There was a problem hiding this comment.
I thought it should be OK now because of linear IR, but I could be wrong. CI seems OK with it.
|
After some off line discussion, we agreed that there are probably some easy case where this is needed previously. Right now, this change should be valid if we assume all objects (special types or not, big or small) are promoted under the same rule. I’m 90% sure that is the case now so it should be fine....... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.