-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve REPL printing of UmfpackLU #33705
Conversation
Even the dense LU seems to show too much in my opinion. I wonder if we should show less output for the dense LU. |
I don't see any downsides in showing some detailed information about a performed matrix factorization. It's much more visually appealing than just showing a type (or something similar) in my opinion. And it only affects REPL sessions, where the user usually wants to have some interaction. Furthermore it can easily be prevented by adding a |
I agree with that - but this scrolls to two screenfuls! My preference would be to show fewer entries and restrict the printing to be about half a screenful. |
To achieve this, we would need to crop the displayed matrices in a more aggressive manner, e.g. restrict the number of shown entries to 10. I would suggest to address this as a follow-up of JuliaLang/LinearAlgebra.jl#485, because it's not only about LU, but also all the other factorization types. |
I think we should definitely get rid of the |
On better printing of sparse matrices, there's also: #30587 |
@ViralBShah Thanks, this is definitely interesting! |
This PR is somewhat independent from the sparse printing, isn't it? Whatever is going on there, will be simply pasted in here, IIUC. Thus, ignoring that aspect, is this PR then acceptable? I'd say it's very much in line with what we have for other factorizations. |
Given the development in the sparse printing I also think this is fine as it is. |
This PR addresses another issue from JuliaLang/LinearAlgebra.jl#485.
Consider this code:
Prior to this PR, the LU factorization looked like this:
Now it is shown in the same manner as the LU factorization of a dense matrix: