Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen: re-add support for structs appearing as values #33597

Merged
merged 3 commits into from
Oct 21, 2019

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 17, 2019

(split off from #33389)

@vtjnash vtjnash requested a review from Keno October 17, 2019 18:52
@vchuravy
Copy link
Member

While you are touching this code, we shout probably assert that Julia and LLVM use the same alignment (x-ref #32414)

@vtjnash
Copy link
Member Author

vtjnash commented Oct 18, 2019

I'm not currently touching that part of the code.

Currently inactive, since we don't (usually) emit this.
But it does give us some more flexibility to have it.
@vtjnash vtjnash force-pushed the jn/codegen-structvals branch from dde3744 to 6f13a87 Compare October 18, 2019 20:00
@vtjnash vtjnash merged commit 7b826ba into master Oct 21, 2019
@vtjnash vtjnash deleted the jn/codegen-structvals branch October 21, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants