improve instanceof_tfunc
to take declared parameter bounds into account
#33472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following inference performance issue identified by @andreasnoack :
(except on master it's even worse)
What happened here was that a type got inferred as
CartesianIndices{A,B} where {A,B}
--- there are no limits on A and B even though the type has some declared bounds. That in turn caused us to infer into methods that actually could not be applicable, because we thoughtiterate(::CartesianIndices)
might not cover every case. That led to a lot of recursion that made it very hard to infer a lot of code.It's a bit lucky that this ends up being enough to fix it. Does not help #33336.