Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileWatching,test: remove max timeout #33316

Merged
merged 1 commit into from
Sep 19, 2019
Merged

FileWatching,test: remove max timeout #33316

merged 1 commit into from
Sep 19, 2019

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Sep 18, 2019

This has been pretty flaky on CI systems, and isn't really required of the tests.

fix #33311

This has been pretty flaky on CI systems, and isn't really required of the tests.

fix #33311
@test 0.001 <= @elapsed(@test(watch_folder(dir, 0.004) == ("" => FileWatching.FileEvent()))) <= 2
@test 0.001 <= @elapsed(@test(watch_folder(dir, 0.004) == ("" => FileWatching.FileEvent()))) <= 0.5
@test 0.002 <= @elapsed(@test(watch_folder(dir, 0.004) == ("" => FileWatching.FileEvent())))
@test 0.002 <= @elapsed(@test(watch_folder(dir, 0.004) == ("" => FileWatching.FileEvent()))) <= 0.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this 0.5 be removed as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, 0.004 is less than our internal threshold of 0.01, so this is actually just checking @elapsed sleep(0.004) and not testing the filesystem performance

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, should we remove this test then, if it's not testing filesystem performance?

@JeffBezanson JeffBezanson added ci Continuous integration test This change adds or pertains to unit tests labels Sep 18, 2019
@JeffBezanson JeffBezanson merged commit 872d8ea into master Sep 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the jn/33311 branch September 19, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

watch_folder timeout failure on Windows
3 participants