Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure concurrency_violation is available in Threads #32874

Closed
wants to merge 1 commit into from

Conversation

ararslan
Copy link
Member

The concurrency_violation function is defined in Base and referenced unqualified in the Threads submodule, which means that instead of actually getting a concurrency violation error, you get an UndefVarError regarding concurrency_violation.

Fixes #32873.

The `concurrency_violation` function is defined in Base and referenced
unqualified in the Threads submodule, which means that instead of
actually getting a concurrency violation error, you get an
`UndefVarError` regarding `concurrency_violation`.
@ararslan ararslan added multithreading Base.Threads and related functionality bugfix This change fixes an existing bug labels Aug 12, 2019
@ararslan ararslan requested a review from JeffBezanson August 12, 2019 17:29
Copy link
Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but someone with knowledge of the emperor's new threads should probably take a glance.

@JeffBezanson
Copy link
Member

This is ok, but not needed, since the Mutex type will be deleted.

@ararslan
Copy link
Member Author

Is there an open PR that does that? Seems like we should probably have this in the meantime in case people are using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug multithreading Base.Threads and related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UndefVarError: concurrency_violation not defined
4 participants