threads: further optimize scheduler based on #32551 #32599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
performance
JeffBezanson
approved these changes
Jul 16, 2019
vtjnash
force-pushed
the
jn/32511-optim
branch
2 times, most recently
from
998b5ae to
e8a60f5
Compare
|
WTF? Why did the Linux buildbot fail and also segfault? The changes here are thought to be an obvious no-op. |
vtjnash
force-pushed
the
jn/32511-optim
branch
from
256b831 to
4890982
Compare
|
I think this is acceptable to merge now. I'll add back the other couple changes in other PRs. |
vtjnash
force-pushed
the
jn/32511-optim
branch
from
4890982 to
f2039a3
Compare
vtjnash
force-pushed
the
jn/32511-optim
branch
2 times, most recently
from
078f966 to
0b33b69
Compare
vtjnash
force-pushed
the
jn/32511-optim
branch
from
0b33b69 to
b51e3f4
Compare
vtjnash
force-pushed
the
jn/32511-optim
branch
from
722af88 to
742cd1f
Compare
And add some debugging aids, controlled by changing the `JULIA_DEBUG_SLEEPWAKE()` macro in `julia_threads.h` Eliminates the `sleep_check_state` global, equal to `any(ptls->sleep_check_state == true)`
vtjnash
force-pushed
the
jn/32511-optim
branch
from
742cd1f to
65b8e7e
Compare
This was referenced Mar 31, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add some debugging aids, controlled by changing the JULIA_DEBUG_SLEEPWAKE() macro in julia_threads.h