-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SparseMatrixCSC constructors for structured matrices - Diagonal, Tridiagonal, etc. #32466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It would be good to get some tests in and merge.
There exist these: julia/stdlib/SparseArrays/test/sparse.jl Lines 1463 to 1479 in 4b6ab68
Since On a different note, I have code that does what was asked for in #10843 (comment). I could add it here and leave the individual commits for review, or open another PR. Edit: It may make sense to merge this as is and then have another PR in which the |
I agree. Merged this one in - but we can have further optimizations if you already have them in a separate PR. |
Will this be backported? |
Triage should decide whether this goes into 1.2. |
This is a feature, so no. |
This keeps identical functionality, but makes the specialized constructors for structured matrices such as
Diagonal
,Bidiagonal
etc. available to the broadcast machinery.Fixes #31770.