Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

efficient subset query for unit ranges #32463

Merged
merged 2 commits into from
Jul 2, 2019
Merged

efficient subset query for unit ranges #32463

merged 2 commits into from
Jul 2, 2019

Conversation

mcabbott
Copy link
Contributor

@mcabbott mcabbott commented Jul 1, 2019

This should fix #32461 .

See also #32003, which will make issubset([1,2,3], 1:10^8) not take 5 seconds.

Should I add more methods for StepRange, or keep this simple?

@mbauman
Copy link
Member

mbauman commented Jul 1, 2019

Nice! I say we keep things simple and incrementally add these optimizations in separate PRs.

mbauman
mbauman reviewed Jul 1, 2019
View reviewed changes
Copy link
Member

@mbauman mbauman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the trailing whitespace

base/range.jl Outdated Show resolved Hide resolved
test/ranges.jl Outdated Show resolved Hide resolved
@JeffBezanson JeffBezanson merged commit 49fc01a into JuliaLang:master Jul 2, 2019
@mcabbott mcabbott deleted the subsets branch July 24, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbauman mbauman mbauman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

efficient subset query for ranges
3 participants
@mcabbott @mbauman @JeffBezanson