-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fixed in read_to_buffer #32457
bug fixed in read_to_buffer #32457
Conversation
Looks good to me if you add tests. |
@bicycle1885 I've added a few tests |
Hi @JeffBezanson @bicycle1885 -- any feedback? Am I missing anything?
IMO using code coverage might have revealed that the existing tests weren't triggering that part of the code. |
This looks good to me now But since I have no permission to merge, we need to ask someone else to merge. |
fixed a bug in buffer.jl triggered when read_to_buffer is called on a non empty buffer.
This is related to #32397.