Make getindex
for Bidiagonal
O(1) in the worst-case
#32329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #32328, but I separated them since that is a bug fix and this is just an edge case optimization.
In the worst case,
getindex
forBidiagonal
matrices isO(n)
. This PR makes itO(1)
.The worst case is a
Bidiagonal
where the off diagonal is zero. In the worst case,iszero
(which isO(n)
) is called twice (once inistriu
and once inistril
).This only really comes into play for large matrices, but this pr doesn't slow down
getindex
for small matrices, so it seems like a net win.Here are some timings:
Master:
This PR: