Error checking in nagle and quickack
#32292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib/Sockets/src/Sockets.jl
Outdated
| r = ccall(:uv_tcp_nodelay, Cint, (Ptr{Cvoid}, Cint), sock.handle, Cint(!enable)) | ||
| if r < 0 | ||
| enable_disable = ifelse(enable, "enable", "disable") | ||
| @warn "Cannot $(enable_disable) Nagle's algorithm ( Error: $(Libc.strerror(Libc.errno())) )" maxlog=1 |
There was a problem hiding this comment.
Having spaces inside of parens like this is not standard in Julia error messages. Maybe have the error message on a new line?
There was a problem hiding this comment.
It would be more standard now to use the exception kwarg
There was a problem hiding this comment.
I've changed it, the error is now printed using the exception kwarg.
mateuszbaran
force-pushed
the
mbaran/nagle-error-checking
branch
from
40763ea to
57896e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here: #31924 (comment) I've added error checking to
nagle. The error checking inquickackis modified to take into account value of theenableargument.