Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run threads test with and without nthreads > 1 #32284

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Conversation

JeffBezanson
Copy link
Member

Run the threads test with actual multiple threads. This runs them with both nthreads==1 and nthreads==4. I also removed the "loop executed in order" warning when nthreads==1.

@JeffBezanson JeffBezanson added test This change adds or pertains to unit tests multithreading Base.Threads and related functionality labels Jun 10, 2019
@JeffBezanson
Copy link
Member Author

JeffBezanson commented Jun 12, 2019

Hmm, seems to hang on windows.

@JeffBezanson JeffBezanson force-pushed the jb/threadstest branch 2 times, most recently from a36956a to 90069e0 Compare June 21, 2019 18:25
@JeffBezanson JeffBezanson merged commit a3ac7b9 into master Jul 2, 2019
@JeffBezanson JeffBezanson deleted the jb/threadstest branch July 2, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multithreading Base.Threads and related functionality test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant