Use LLVM_DEBUG instead of DEBUG in final GC lowering pass #32265
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! After reviewing @chriselrod's comment on #31135, I discovered a small flaw in said PR. The changes I'm proposing here fix that flaw.
Specifically, I discovered that @banex19 had prepared Julia's LLVM IR optimization passes for LLVM 7.0.1 by replacing calls to the
DEBUGmacro with calls to the newLLVM_DEBUGmacro in 4e8bae3. These changes appear to have been made after I first posted #31135 but before it got merged in. I must've overlooked them when I rebased and hence didn't updatellvm-final-gc-lowering.cppto also useLLVM_DEBUGrather thanDEBUG. Sorry about that!