relax some Diagonal tests from #31443 #32162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
approved these changes
May 28, 2019
|
Applying the same backport labels as #31443 — this commit should follow that PR around. |
JeffBezanson
pushed a commit
that referenced
this pull request
Jun 6, 2019
JeffBezanson
pushed a commit
that referenced
this pull request
Jun 7, 2019
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
55 tasks
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #31443 (comment)
As in the comment by @nalimilan, the current tests seem to fail on some architectures only, including Julia v1.0.4, so this should be backported once agreed on.