-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename test/bigint.jl to test/gmp.jl #31992
Conversation
Need to update Line 43 in 829a4a6
|
f5f6937
to
39cc9b3
Compare
Ah yeah thanks, I just realised too! |
I wonder if we shouldn't change in the other direction—use |
This makes a lot of sense to me. On the other hand, it's somewhat practical to have the filenames reflect the name of the contained modules. |
We could change the names of those modules too. If breaking code that reaches into them is a concern, we could just do |
I think we should merge this. If somebody wants to do the renaming the other way (gmp -> bigint) they can, but in the meantime the filenames will be more consistent. |
For consistency with base/gmp.jl and test/mpfr.jl.
39cc9b3
to
f14544c
Compare
I realize this was a bit silly of me to add the triage label, I will just merge when CI is green as Jeff suggested. |
For consistency with base/gmp.jl and test/mpfr.jl.
For consistency with base/gmp.jl and test/mpfr.jl.
See #29144 (comment).