Improve some aspects of the NSIS installer #31959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
May 7, 2019
|
I also want to change |
|
Yes, "The Julia Language" reads weird in many of those screens. It should just be "Julia". |
ViralBShah
added
building
musm
force-pushed
the
nsisfix
branch
3 times, most recently
from
ce8aecf to
c3909d7
Compare
|
Updated PR, this should be ready for review. (See updated first post for the latest installer pictures) |
|
Also this PR should not be squashed on merge |
musm
force-pushed
the
nsisfix
branch
2 times, most recently
from
40daf41 to
f5661cb
Compare
|
I pushed a cosmetic change, but otherwise this is good to go from my end. |
vtjnash
approved these changes
May 10, 2019
musm
added a commit
to musm/julia
that referenced
this pull request
Aug 7, 2019
(cherry picked from commit 9d6fffe)
musm
added a commit
to musm/julia
that referenced
this pull request
Aug 7, 2019
(cherry picked from commit 9d6fffe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit adds a missing NSIS checksum
Second commit upgrades NSIS (also must enable Unicode to the installer)
Third commit improves the NSIS installer appearance (see figures below for the changes)
NEW INSTALLER
.
.
.
OLD INSTALLER