Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation of check_top_bit #31883

Merged
merged 1 commit into from
May 3, 2019
Merged

fix compilation of check_top_bit #31883

merged 1 commit into from
May 3, 2019

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Apr 30, 2019

fixes #31819

We could try to do something complicated to ensure this doesn't happen elsewhere, but this is a quick pragmatic fix.

@vchuravy
Copy link
Member

Since this is in particular necessary for the GPU, how hard would it be to add a Param that ignores @nospecialize?

@JeffBezanson
Copy link
Member

Is it no longer possible to compile efficient calls to functions with @nospecialize, or does this just happen sometimes?

@vtjnash
Copy link
Member Author

vtjnash commented Apr 30, 2019

The @nospecialize was a no-op here and is a red-herring, but this just happens sometimes (usually with cold code paths like here)

@vtjnash vtjnash merged commit 4111609 into master May 3, 2019
@vtjnash vtjnash deleted the jn/31819 branch May 3, 2019 13:05
KristofferC pushed a commit that referenced this pull request May 9, 2019
addresses #31819

(cherry picked from commit 4111609)
@KristofferC KristofferC mentioned this pull request May 9, 2019
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codegen regression in check_top_bit after MethodInstance/CodeInstance split
4 participants