Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: LDFLAGS needed for FreeBSD build #31586

Merged
merged 1 commit into from
Apr 2, 2019
Merged

build: LDFLAGS needed for FreeBSD build #31586

merged 1 commit into from
Apr 2, 2019

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Apr 2, 2019

also submitted to [email protected] patch list

@vtjnash vtjnash requested a review from staticfloat April 2, 2019 18:47
staticfloat
staticfloat approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@staticfloat staticfloat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting this.

@vtjnash
Copy link
Member Author

vtjnash commented Apr 2, 2019

Thanks. I realize we don't have tests for any of this code anymore, but I guess it's good anyways.

@ararslan ararslan added building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries system:freebsd Affects only FreeBSD labels Apr 2, 2019
@ararslan ararslan merged commit b446398 into master Apr 2, 2019
@ararslan ararslan deleted the jn/gmp-freebsd branch April 2, 2019 22:47
@vchuravy vchuravy mentioned this pull request Apr 16, 2019
Merged
39 tasks
KristofferC pushed a commit that referenced this pull request Apr 16, 2019
@vtjnash @KristofferC
build: LDFLAGS needed for FreeBSD build (#31586)
ec2a819 
also submitted to [email protected] patch list

(cherry picked from commit b446398)
KristofferC pushed a commit that referenced this pull request Apr 17, 2019
@vtjnash @KristofferC
build: LDFLAGS needed for FreeBSD build (#31586)
5c8cd40 
also submitted to [email protected] patch list

(cherry picked from commit b446398)
KristofferC pushed a commit that referenced this pull request Apr 20, 2019
@vtjnash @KristofferC
build: LDFLAGS needed for FreeBSD build (#31586)
ce6b3cb 
also submitted to [email protected] patch list

(cherry picked from commit b446398)
@KristofferC KristofferC mentioned this pull request Aug 26, 2019
Merged
55 tasks
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@vtjnash @KristofferC
build: LDFLAGS needed for FreeBSD build (#31586)
efcd50f 
also submitted to [email protected] patch list

(cherry picked from commit b446398)
@fingolfin fingolfin mentioned this pull request Jun 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries system:freebsd Affects only FreeBSD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vtjnash @staticfloat @ararslan @vchuravy @KristofferC