-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstrings for days of the week #31574
Conversation
How about this pattern instead: const Monday, ...., = 1, ...
const Mon, ..., = 1, ...
"""
Monday
Mon
The first day of the week.
# Examples
```jldoctest
julia> Monday
1
```
"""
Mon, Monday
... |
@fredrikekre I tried to match the pattern already in place for the months. |
Change that too then :) I just think it is completely unecessary to maintain two different docstrings for aliases to the integers 1-7 (and 1-12 for the months). |
Is it possible to attache a single doc string to the symbols for the days? It would be pretty weird for the Monday doc string to be attached to the number 1. |
x-ref #31202 |
@fredrikekre is this better? I checked and tests passed and docs build (and the docstring lookup works). |
Win32 and Travis errors are unrelated. |
I still don't think we need separate docstrings for the long and short names, why not just
etc? |
Now even more sm0l |
Anything else we want for this? |
Following #31218...