Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc free_memory and total_memory #31297

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Doc free_memory and total_memory #31297

merged 1 commit into from
Mar 11, 2019

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Mar 8, 2019

No description provided.

@kshyatt kshyatt added the docs This change adds or pertains to documentation label Mar 8, 2019
@kshyatt kshyatt requested a review from StefanKarpinski March 8, 2019 13:27
KristofferC
KristofferC reviewed Mar 8, 2019
View reviewed changes
base/sysinfo.jl Outdated
"""
Sys.total_memory()

Get the total memory in RAM (used and unused) in kilobytes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The (used and unused) comment made it feel like this returned a 2-tuple or something. Perhaps just

Get the total memory of the RAM

or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe (including that which is currently used)? I want to make sure it's clear that it includes allocated memory too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mbauman mbauman mentioned this pull request Mar 9, 2019
Closed
@kshyatt
Copy link
Contributor Author

kshyatt commented Mar 11, 2019

Failing Pkg test on OSX

@kshyatt kshyatt merged commit 86fcbc7 into master Mar 11, 2019
@kshyatt kshyatt deleted the ksh/mem branch March 11, 2019 20:08
@mauro3
Copy link
Contributor

mauro3 commented Mar 14, 2019

I think this is in bytes not kilobytes as on my 16GB ram system I get:

julia> Sys.total_memory()/1e9
16.62783488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC left review comments

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kshyatt @mauro3 @StefanKarpinski @KristofferC