Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of a predicate function in strip docstring #31213

Merged
merged 1 commit into from
Mar 3, 2019

Conversation

ararslan
Copy link
Member

lstrip and rstrip take a predicate function as the first argument. It seems strip did not receive that addition, though its docstring suggests that it did.

See #31195, which reported the issue, and #31211, which implements the method in question.

`lstrip` and `rstrip` take a predicate function as the first argument.
It seems `strip` did not receive that addition, though its docstring
suggests that it did.

See #31195.
@ararslan ararslan added docs This change adds or pertains to documentation strings "Strings!" triage This should be discussed on a triage call backport 1.0 labels Feb 28, 2019
@StefanKarpinski StefanKarpinski merged commit a6d34ff into master Mar 3, 2019
@StefanKarpinski StefanKarpinski deleted the aa/no-strip-pred branch March 3, 2019 01:55
@KristofferC KristofferC removed backport 1.0 triage This should be discussed on a triage call labels Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation strings "Strings!"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants