another improvement to closure analysis precision #30972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
performance
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
|
There is a small memory regression in one of the io tests but I believe it is data-dependent. I'm able to get similar fluctuations locally for different random arrays. |
|
Yes, it is known to fluctuate. |
JeffBezanson
force-pushed
the
jb/moreclosures
branch
from
a4957ca to
48eea57
Compare
|
Ugh I found a crazy test case. goto ruins everything!! 😛 |
|
disable it if there's a gotolabel? 😜 |
|
Yeah, pretty much :) |
JeffBezanson
added a commit
that referenced
this pull request
May 24, 2019
JeffBezanson
added a commit
that referenced
this pull request
Jun 6, 2019
JeffBezanson
added a commit
that referenced
this pull request
Jun 7, 2019
55 tasks
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the case where an assignment dominates all uses, but there are intervening
ifblocks. Also simplifies the implementation a bit.helps #15276
@nanosoldier
runbenchmarks(ALL, vs = ":master")