Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some better type info in Base to improve latency a bit #30830

Merged
merged 2 commits into from
Feb 8, 2019
Merged

some better type info in Base to improve latency a bit #30830

merged 2 commits into from
Feb 8, 2019

Conversation

JeffBezanson
Copy link
Member

No description provided.

@JeffBezanson JeffBezanson added the compiler:latency Compiler latency label Jan 24, 2019
@JeffBezanson
Copy link
Member Author

fixes #29166

@vtjnash vtjnash added the needs nanosoldier run This PR should have benchmarks run on it label Jan 25, 2019
@JeffBezanson
Copy link
Member Author

@nanosoldier runbenchmarks(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@KristofferC
Copy link
Member

["dates", "string", "Date"] might be real

@JeffBezanson
Copy link
Member Author

Yes, I can reproduce that regression locally. It's hard to see what caused it. It seems to be one of those indirect effects. There is no difference in code_typed, but code_llvm shows that calls to the implementation method (inside the keyword args wrapper) for string(::Int) are using jl_invoke instead of direct calls.

@JeffBezanson JeffBezanson added DO NOT MERGE Do not merge this PR! and removed needs nanosoldier run This PR should have benchmarks run on it labels Jan 28, 2019
@JeffBezanson JeffBezanson mentioned this pull request Jan 31, 2019
Merged
@JeffBezanson JeffBezanson removed the DO NOT MERGE Do not merge this PR! label Feb 7, 2019
@JeffBezanson
Copy link
Member Author

@nanosoldier runbenchmarks("dates", vs = ":master")

@JeffBezanson
improve some type information to reduce backedges; fixes #29166
560bf4a 
reuse `Base._array_for` in lowering instead of manually inlining it
@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - no performance regressions were detected. A full report can be found here. cc @ararslan

@JeffBezanson JeffBezanson merged commit a0bb006 into master Feb 8, 2019
@JeffBezanson JeffBezanson deleted the jb/misclatency branch February 8, 2019 03:42
@timholy timholy mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compiler:latency Compiler latency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeffBezanson @nanosoldier @KristofferC @vtjnash