improve checking of malformed using/import Exprs
#30799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I'll be. Looks like this exposed a bug in |
JeffBezanson
force-pushed
the
jb/malformedusing
branch
from
d279f95 to
bf2289e
Compare
|
backport? |
StefanKarpinski
added
triage
JeffBezanson
removed
backport 1.0
triage
This was referenced Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by https://discourse.julialang.org/t/internal-representation-of-using-foo/19771
We were missing some checks in the interpreter and
showfor malformedusingexprs. One case could crash, and some others just did nothing instead of reporting an error.The AST devdocs mentioned
importbut notusing, so add that. Also put AST docs first since they are important to macro authors. The IR part should perhaps be moved to a separate file.