some latency hacks #30566
Merged
some latency hacks #30566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base/array.jl
Outdated
| @@ -279,7 +279,7 @@ end | |||
| # occurs, see discussion in #27874 | |||
| function _throw_argerror(n) | |||
There was a problem hiding this comment.
Couldn't you remove the n argument then?
These changes cut some method dependency edges that tend to lead to invalidations when loading packages.
JeffBezanson
force-pushed
the
jb/latency13
branch
from
819a78f to
cfc7a78
Compare
Too hacky for backporting? |
|
Yes, I think we probably shouldn't backport this. |
|
I would argue we should put this in 1.1.0. The gain here seems overwhelmingly larger compared to a slightly less informative error message. |
|
Merge? |
KristofferC
pushed a commit
that referenced
this pull request
Jan 9, 2019
These changes cut some method dependency edges that tend to lead to invalidations when loading packages. (cherry picked from commit 13fc4c3)
vchuravy
pushed a commit
to JuliaLang/Distributed.jl
that referenced
this pull request
Oct 6, 2023
These changes cut some method dependency edges that tend to lead to invalidations when loading packages. (cherry picked from commit 5e56fd9)
Keno
pushed a commit
that referenced
this pull request
Jun 5, 2024
These changes cut some method dependency edges that tend to lead to invalidations when loading packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes cut some method dependency edges that tend to lead to invalidations when loading packages. Cuts another 10-15 seconds off the time to precompile DataFrames. Hopefully knowing the exact negative element count passed to
copyto!is not essential.