Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two missing tests for sprand #30551

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Two missing tests for sprand #30551

merged 1 commit into from
Jan 2, 2019

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Jan 1, 2019

Attempting to grab these.

@kshyatt kshyatt added test This change adds or pertains to unit tests sparse Sparse arrays labels Jan 1, 2019
@kshyatt kshyatt requested a review from Sacha0 January 1, 2019 18:17
Sacha0
Sacha0 approved these changes Jan 1, 2019
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @kshyatt! :)

Also happy new year! 🎉

@kshyatt
Copy link
Contributor Author

kshyatt commented Jan 1, 2019

Thanks, @Sacha0 🎉 happy new year to you too!

@andreasnoack andreasnoack merged commit 2c64220 into master Jan 2, 2019
@StefanKarpinski StefanKarpinski deleted the ksh/sprand branch January 2, 2019 13:39
@kshyatt kshyatt mentioned this pull request Jan 2, 2019
Merged
@kshyatt
Copy link
Contributor Author

kshyatt commented Jan 3, 2019

Got em!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 approved these changes

Assignees
No one assigned
Labels
sparse Sparse arrays test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kshyatt @Sacha0 @andreasnoack