Fixed sprand for dimensions of unusual integer type #30516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should also fix |
|
Please re review this PR. |
|
@raghav9-97 PRs do get reviewed as you submit them (unless you put WIP in the title). In general, you want to bump it up for review if it has not received any attention in about 3-4 days. Hope that helps. Of course, this being holidays, it is likely to take longer. |
ViralBShah
requested changes
Dec 26, 2018
| @test sprand(UInt8(16), UInt8(16), 1.0) != spzeros(UInt8(16), UInt8(16)) | ||
| @test sprand(Int8(16), Int8(16), 1.0) != spzeros(Int8(16), Int8(16)) | ||
| @test sprand(UInt8(16), UInt8(16), 1.0, ones) != spzeros(UInt8(16), UInt8(16)) | ||
| end |
There was a problem hiding this comment.
Can we have a test that checks correctness of the intended answer with ==? Also, only one test for each of the changed functions would be enough here.
ViralBShah
changed the title
|
Is this PR now ready to be merged? |
staticfloat
pushed a commit
that referenced
this pull request
Dec 30, 2018
staticfloat
pushed a commit
that referenced
this pull request
Jan 4, 2019
KristofferC
pushed a commit
that referenced
this pull request
Jan 11, 2019
StefanKarpinski
added
triage
StefanKarpinski
added
backport 1.0
triage
JeffBezanson
removed
backport 1.0
triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30502.