use type inference world in return_type
#30470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backport eligible for 1.0.x or 1.1? |
vtjnash
approved these changes
Dec 20, 2018
| @@ -633,7 +633,12 @@ end | |||
|
|
|||
|
|
|||
| function return_type(@nospecialize(f), @nospecialize(t)) | |||
| params = Params(ccall(:jl_get_tls_world_age, UInt, ())) | |||
| world = ccall(:jl_get_tls_world_age, UInt, ()) | |||
| return ccall(:jl_call_in_typeinf_world, Any, (Ptr{Ptr{Cvoid}}, Cint), Any[_return_type, f, t, world], 4) | |||
There was a problem hiding this comment.
Ptr{Any} might be more accurate, although legacy C compatibility generally demands that Cvoid is the same, I think escape analysis may see them differently.
JeffBezanson
force-pushed
the
jb/rettypeworld
branch
from
ef5545f to
27f7d7d
Compare
|
Note that if this is backported it requires #30483. |
KristofferC
pushed a commit
that referenced
this pull request
Jan 9, 2019
(cherry picked from commit a5a5882)
This was referenced Jan 9, 2019
Closed
StefanKarpinski
added
backport 1.0
triage
StefanKarpinski
added
triage
JeffBezanson
removed
triage
KristofferC
pushed a commit
that referenced
this pull request
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that one large source of latency in code loading is that we're repeatedly compiling the type inference code when it's called from
return_type, since the type inference code in the system image is for a different world. This instead re-uses the precompiled world.Significantly helps #15048. With this, precompiling DataFrames goes from 77 to 50 seconds, and precompiling JuliaDB goes from 130 to 75 seconds.