Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use llvm-config for library selection with USE_SYSTEM_LLVM #30459

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Only use llvm-config for library selection with USE_SYSTEM_LLVM #30459

merged 1 commit into from
Dec 21, 2018

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Dec 20, 2018

Partial revert of #29446, ref #29981 (comment)

@maleadt maleadt added this to the 1.1 milestone Dec 20, 2018
@maleadt maleadt added building Build system, or building Julia or its dependencies bugfix This change fixes an existing bug labels Dec 20, 2018
@maleadt
Copy link
Member Author

maleadt commented Dec 20, 2018

@eli-schwartz Could you confirm this still works on your set-up?

@maleadt
Copy link
Member Author

maleadt commented Dec 20, 2018

BSD failure looks unrelated:

      From worker 6:	Assertion failed: (e && ptls->bt_size != 0), function jl_sig_throw, file /usr/home/julia/julia-fbsd-buildbot/worker/freebsdci/build/src/task.c, line 437.
      From worker 6:	
      From worker 6:	signal (6): Abort trap
      From worker 6:	in expression starting at /usr/home/julia/julia-fbsd-buildbot/worker/freebsdci/build/test/arrayops.jl:1684
      From worker 6:	_thr_kill at /lib/libc.so.7 (unknown line)
      From worker 6:	__raise at /lib/libc.so.7 (unknown line)
      From worker 6:	abort at /lib/libc.so.7 (unknown line)
      From worker 6:	__assert at /lib/libc.so.7 (unknown line)
      From worker 6:	jl_sig_throw at /usr/home/julia/julia-fbsd-buildbot/worker/freebsdci/build/src/task.c:437
      From worker 6:	unknown function (ip: 0xffffffffffffffff)
      From worker 6:	Allocations: 202207673 (Pool: 202165690; Big: 41983); GC: 447

@ararslan
Copy link
Member

I've restarted the FreeBSD build just to be sure.

@maleadt
Copy link
Member Author

maleadt commented Dec 21, 2018

Good to go? This should be backported to 1.1, right? Isn't an issue on 1.0.

@ararslan ararslan requested a review from staticfloat December 21, 2018 22:46
@ararslan ararslan merged commit 7acb991 into master Dec 21, 2018
@ararslan ararslan deleted the tb/29981 branch December 21, 2018 23:33
@maleadt maleadt mentioned this pull request Dec 22, 2018
Merged
@maleadt
Copy link
Member Author

maleadt commented Dec 22, 2018 •
edited
Loading

Great, this works and makes LLVM.jl and CUDAnative.jl work again on 1.1 Windows/macOS.

KristofferC pushed a commit that referenced this pull request Dec 27, 2018
@maleadt @KristofferC
Only use llvm-config for library selection when building against syst…
4e97adf 
…em LLVM. (#30459)

(cherry picked from commit 7acb991)
@KristofferC KristofferC mentioned this pull request Dec 27, 2018
Merged
52 tasks
staticfloat pushed a commit that referenced this pull request Dec 30, 2018
@maleadt @staticfloat
Only use llvm-config for library selection when building against syst…
bba1726 
…em LLVM. (#30459)
staticfloat pushed a commit that referenced this pull request Jan 4, 2019
@maleadt @staticfloat
Only use llvm-config for library selection when building against syst…
879fdba 
…em LLVM. (#30459)
@maleadt maleadt mentioned this pull request Jan 17, 2019
Closed
carlocab added a commit to carlocab/julia that referenced this pull request May 1, 2021
@carlocab
Limit use of llvm-config with USE_SYSTEM_LLVM on Darwin
8675648 
As noted in JuliaLang#29981 and JuliaLang#30459, `llvm-config` is broken on Darwin, and
sadly hasn't been fixed since then.

Building Julia on Darwin with `USE_SYSTEM_LLVM` doesn't currently work,
as calls to `llvm-config` produce the wrong flags. This PR fixes that.
@carlocab carlocab mentioned this pull request May 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug building Build system, or building Julia or its dependencies
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@maleadt @ararslan @staticfloat @KristofferC