-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom deserialize method for UmfpackLU to avoid memory leak #30425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
added
sparse
Sparse arrays
bugfix
This change fixes an existing bug
backport pending 1.0
labels
Dec 17, 2018
Do we have to do it for all the factorizations in SuiteSparse? |
You will have to add |
andreasnoack
force-pushed
the
an/umfpackleak
branch
from
December 19, 2018 20:57
c3b5b2e
to
185d33a
Compare
andreasnoack
force-pushed
the
an/umfpackleak
branch
from
January 2, 2019 15:09
185d33a
to
210063f
Compare
KristofferC
pushed a commit
that referenced
this pull request
Jan 11, 2019
) Fixes #15450 (cherry picked from commit 356ceee)
StefanKarpinski
added
triage
This should be discussed on a triage call
backport 1.0
and removed
triage
This should be discussed on a triage call
backport 1.0
labels
Jan 31, 2019
JeffBezanson
removed
triage
This should be discussed on a triage call
triage backport pending 1.0
labels
Jan 31, 2019
KristofferC
pushed a commit
that referenced
this pull request
Feb 4, 2019
) Fixes #15450 (cherry picked from commit 356ceee)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
) Fixes #15450 (cherry picked from commit 356ceee)
KristofferC
pushed a commit
that referenced
this pull request
Apr 20, 2019
) Fixes #15450 (cherry picked from commit 356ceee)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
) Fixes #15450 (cherry picked from commit 356ceee)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JuliaLang/LinearAlgebra.jl#317
I'm not sure what would be a good way to test this. Can I compare some of the values from the GC output before and after running
Which of the gc values would be appropriate to compare?