-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coverage: support output in LCOV tracefile format #30381
Conversation
Adding a test and removing the unnecessary comments would make this good to go from my perspective. I'm just kind of assuming that the info it generates is good; I haven't run it locally to check it, which is why I'm particularly interested in a test. |
OK, I added a small test so we'll be alerted earlier if coverage output changes. I had tested the results locally with genhtml to see that it looked valid, and more recently now have also checked that my PRs to Coverage.jl and CoverageBase.jl are successful at analyzing a sample file. |
3e9c893
to
d585095
Compare
Why is this on the milestone? It adds a new command line option, which is a new feature. |
Rebased as #30453 for release-1.1. |
11ce9f3
to
c1609fe
Compare
Also ensure that `julia_cmd` is forwarding all desirable options, and provide a general framework for specifying formatted filenames for similar such options.
c1609fe
to
b920e71
Compare
a) Where is the documentation about how to use this? b) I've been doing some investigating into why code coverage for LightQuery seems low despite the recent improvements. I tried running the command
This gives me a 'tracefile-DIGITS.info' file in my test directory. I can view this info in Atom using the lcov-info package (LCOV itself doesn't seem to support windows...), but first I have to make a coverage directory and rename the file to
I just want a green coverage badge halp BTW |
Line 58 points to this macro:
|
Aha! the |
Also, looking at this, I'm noticing |
Turns out I just need to pass |
Since Base code-coverage has been broken for stdlibs for a long time, this adds support for a format that doesn't share the same problems. This'll also allow us to adopt the newly-added code-caches for coverage, and to add handling of them to Coverage.jl similar to that already present in Revise.jl.