Add C-linkage to gc extensions for correct compiling in C++ #30242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Dec 3, 2018
vtjnash
reviewed
Dec 3, 2018
| @@ -1,6 +1,10 @@ | |||
| #ifndef JL_GCEXT_H | |||
There was a problem hiding this comment.
Also missing // This file is a part of Julia. License is MIT: https://julialang.org/license here, but we just should remember to do that for all files before the release (and to add it to our release-candidate checklist in the Makefile)
|
These files do not exist on 1.0 so removing backport label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I failed to compile a C++ project linking against Julia using the new GC extensions and the missing extern-C definitions seem to be the problem.