Update libosxunwind to v0.0.5 #30231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
building
|
I had to flip a conditional, but I think this is good to go now. This compiled on my 10.14 machine as well as my 10.11 machine, so I think we can merge at our leisure. |
staticfloat
approved these changes
Dec 1, 2018
What do you mean? Did you amend the actual v0.0.5 release of libosxunwind? |
|
Does the request for review mean that I should try building this commit to make sure it works? |
|
Yes please |
|
Though Elliot said he did a 10.14 build and it worked, so you don't have to |
|
Happy to give it a try to make sure I don't end up not being able to build master again :) |
|
Build just fine for me too. |
|
Perfect, thanks! |
KristofferC
pushed a commit
that referenced
this pull request
Dec 6, 2018
(cherry picked from commit a26031e)
KristofferC
pushed a commit
that referenced
this pull request
Dec 12, 2018
(cherry picked from commit a26031e)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
(cherry picked from commit a26031e)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
(cherry picked from commit a26031e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works for me on High Sierra. Stefan, could you try out this branch on Mojave?