Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with Git Credential Manager for Windows #30195

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Fix issue with Git Credential Manager for Windows #30195

merged 1 commit into from
Nov 29, 2018

Conversation

omus
Copy link
Member

@omus omus commented Nov 29, 2018

  • Ignores additional whitespace when reading in credentials.
  • Warn when encountering unknown attributes. Should allow for more graceful failures in the future if the protocol is extended.

@omus
Fix issue with Git Credential Manager for Windows
2979082 
- Ignores additional whitespace when reading in credentials.
- Warn when encountering unknown attributes. Should allow for more
  graceful failures in the future if the protocol is extended.
@omus omus added system:windows Affects only Windows libgit2 The libgit2 library or the LibGit2 stdlib module bugfix This change fixes an existing bug backport pending 1.0 labels Nov 29, 2018
@arnavs
Copy link
Contributor

arnavs commented Nov 29, 2018

Thanks for being so responsive on this @omus

@omus
Copy link
Member Author

omus commented Nov 29, 2018 •
edited
Loading

Originally reported on Slack by @arnavs:

┌ Warning: a SecretBuffer was `shred!`ed by the GC; use `shred!` manually after use to minimize exposure.
└ @ Base secretbuffer.jl:169
ERROR: type GitCredential has no field

Stacktrace:
 [1] getproperty at .\sysimg.jl:18 [inlined]
 [2] read!(::Base.Process, ::LibGit2.GitCredential) at C:\cygwin\home\Administrator\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.0\LibGit2\src\gitcredential.jl:121

@ararslan ararslan merged commit 4b270b1 into master Nov 29, 2018
@ararslan ararslan deleted the cv/git-windows-cred-manager branch November 29, 2018 21:49
KristofferC pushed a commit that referenced this pull request Dec 6, 2018
@omus @KristofferC
Fix issue with Git Credential Manager for Windows (#30195)
65227b6 
- Ignores additional whitespace when reading in credentials.
- Warn when encountering unknown attributes. Should allow for more
  graceful failures in the future if the protocol is extended.

(cherry picked from commit 4b270b1)
@KristofferC KristofferC mentioned this pull request Dec 6, 2018
Merged
61 tasks
KristofferC pushed a commit that referenced this pull request Dec 12, 2018
@omus @KristofferC
Fix issue with Git Credential Manager for Windows (#30195)
088ec2f 
- Ignores additional whitespace when reading in credentials.
- Warn when encountering unknown attributes. Should allow for more
  graceful failures in the future if the protocol is extended.

(cherry picked from commit 4b270b1)
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@omus @KristofferC
Fix issue with Git Credential Manager for Windows (#30195)
a4b1201 
- Ignores additional whitespace when reading in credentials.
- Warn when encountering unknown attributes. Should allow for more
  graceful failures in the future if the protocol is extended.

(cherry picked from commit 4b270b1)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@omus @KristofferC
Fix issue with Git Credential Manager for Windows (#30195)
86db4ea 
- Ignores additional whitespace when reading in credentials.
- Warn when encountering unknown attributes. Should allow for more
  graceful failures in the future if the protocol is extended.

(cherry picked from commit 4b270b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug libgit2 The libgit2 library or the LibGit2 stdlib module system:windows Affects only Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omus @arnavs @KristofferC @ararslan