Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use at-DIR instead of Sys.BINDIR to find UnicodeData.txt in doc build. #30012

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Use at-DIR instead of Sys.BINDIR to find UnicodeData.txt in doc build. #30012

merged 1 commit into from
Nov 14, 2018

Conversation

fredrikekre
Copy link
Member

Sys.BINDIR is not correct if one sets the JULIA_EXECUTABLE variable in docs/Makefile.

@fredrikekre fredrikekre added docsystem The documentation building system backport pending 1.0 labels Nov 13, 2018
@fredrikekre
Copy link
Member Author

#29923 x 1

@fredrikekre fredrikekre merged commit fbe86b6 into master Nov 14, 2018
@fredrikekre fredrikekre deleted the fe/doc-build-dir branch November 14, 2018 08:36
KristofferC pushed a commit that referenced this pull request Nov 19, 2018
@fredrikekre @KristofferC
Use at-DIR instead of Sys.BINDIR to find UnicodeData.txt in doc build. (
fc9cb3e 
#30012)

(cherry picked from commit fbe86b6)
@KristofferC KristofferC mentioned this pull request Nov 19, 2018
Merged
61 tasks
tkf pushed a commit to tkf/julia that referenced this pull request Nov 21, 2018
@fredrikekre @tkf
Use at-DIR instead of Sys.BINDIR to find UnicodeData.txt in doc build. (
db2065e 
JuliaLang#30012)
KristofferC pushed a commit that referenced this pull request Dec 12, 2018
@fredrikekre @KristofferC
Use at-DIR instead of Sys.BINDIR to find UnicodeData.txt in doc build. (
dc147c8 
#30012)

(cherry picked from commit fbe86b6)
@fredrikekre fredrikekre mentioned this pull request Dec 18, 2018
Closed
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@fredrikekre @KristofferC
Use at-DIR instead of Sys.BINDIR to find UnicodeData.txt in doc build. (
816255e 
#30012)

(cherry picked from commit fbe86b6)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@fredrikekre @KristofferC
Use at-DIR instead of Sys.BINDIR to find UnicodeData.txt in doc build. (
8a8652d 
#30012)

(cherry picked from commit fbe86b6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docsystem The documentation building system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @KristofferC