fix #29955, intersection bugs involving triangular constraints

[JeffBezanson]

So far I feel this fix is pretty safe, so likely a candidate for backporting. We'll see what the tests say.

@nanosoldier runbenchmarks(ALL, vs = ":master")

[JeffBezanson]

@nanosoldier runbenchmarks(ALL, vs = ":master")

[nanosoldier]

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

[JeffBezanson]

#29923

[JeffBezanson]

On freebsd ci:

LinearAlgebra/bunchkaufman        (16) |    77.66 |   3.61 |  4.6 |    4972.30 |   326.16
      From worker 15:	Assertion failed: (e && ptls->bt_size != 0), function jl_sig_throw, file /usr/home/julia/julia-fbsd-buildbot/worker/freebsdci/build/src/task.c, line 437.
      From worker 15:	
      From worker 15:	signal (6): Abort trap
      From worker 15:	in expression starting at /usr/home/julia/julia-fbsd-buildbot/worker/freebsdci/build/usr/share/julia/stdlib/v1.1/LinearAlgebra/test/lapack.jl:278
      From worker 15:	_thr_kill at /lib/libc.so.7 (unknown line)
      From worker 15:	__raise at /lib/libc.so.7 (unknown line)
      From worker 15:	abort at /lib/libc.so.7 (unknown line)
      From worker 15:	__assert at /lib/libc.so.7 (unknown line)
      From worker 15:	jl_sig_throw at /usr/home/julia/julia-fbsd-buildbot/worker/freebsdci/build/src/task.c:437
      From worker 15:	unknown function (ip: 0xffffffffffffffff)
      From worker 15:	Allocations: 281299313 (Pool: 281243890; Big: 55423); GC: 572
Worker 15 terminated.

Anybody seen this before?

[ararslan]

I definitely haven't. @iblis17?

[iblislin]

🤔 no idea.

[iblislin]

Original build: https://build.julialang.org/#/builders/68/builds/733
I re-built on different works.
Both of them passes now:

• https://build.julialang.org/#/builders/68/builds/753
• https://build.julialang.org/#/builders/68/builds/754

a heisenbug?

[mohamed82008]

Is there anything unsafe about this branch, or can I use it for now to solve #29955?

[mohamed82008]

It seems that tests pass on 64 bits so I will give it a spin.