Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid reading inactive rowvals when computing the rank of a QRSparse #29925

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Avoid reading inactive rowvals when computing the rank of a QRSparse #29925

merged 1 commit into from
Nov 5, 2018

Conversation

andreasnoack
Copy link
Member

@andreasnoack andreasnoack added linear algebra Linear algebra sparse Sparse arrays bugfix This change fixes an existing bug stdlib Julia's standard library backport pending 1.0 labels Nov 4, 2018
fredrikekre
fredrikekre reviewed Nov 5, 2018
View reviewed changes
stdlib/SuiteSparse/src/spqr.jl
@@ -342,7 +342,7 @@ end
_ret_size(F::QRSparse, b::AbstractVector) = (size(F, 2),)
_ret_size(F::QRSparse, B::AbstractMatrix) = (size(F, 2), size(B, 2))

LinearAlgebra.rank(F::QRSparse) = maximum(F.R.rowval)
LinearAlgebra.rank(F::QRSparse) = reduce(max, view(F.R.rowval, 1:nnz(F.R)), init = eltype(F.R.rowval)(0))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use SparseArrays.nzvalview instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using the rowvals here, not the nzvals. We could add rowvalview but I think we should wait until there are more use cases.

@andreasnoack andreasnoack merged commit 911a58c into master Nov 5, 2018
@andreasnoack andreasnoack deleted the an/rank branch November 5, 2018 21:25
KristofferC pushed a commit that referenced this pull request Nov 12, 2018
@andreasnoack @KristofferC
Avoid reading inactive rowvals when computing the rank of a QRSparse (#…
1ef201a 
…29925)

Fixes #29787

(cherry picked from commit 911a58c)
@KristofferC KristofferC mentioned this pull request Nov 12, 2018
Merged
61 tasks
tkf pushed a commit to tkf/julia that referenced this pull request Nov 21, 2018
@andreasnoack @tkf
Avoid reading inactive rowvals when computing the rank of a QRSparse (J…
1a1c02d 
…uliaLang#29925)

Fixes #29787
KristofferC pushed a commit that referenced this pull request Dec 12, 2018
@andreasnoack @KristofferC
Avoid reading inactive rowvals when computing the rank of a QRSparse (#…
4cf85f9 
…29925)

Fixes #29787

(cherry picked from commit 911a58c)
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@andreasnoack @KristofferC
Avoid reading inactive rowvals when computing the rank of a QRSparse (#…
69a636b 
…29925)

Fixes #29787

(cherry picked from commit 911a58c)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@andreasnoack @KristofferC
Avoid reading inactive rowvals when computing the rank of a QRSparse (#…
fd5b2fc 
…29925)

Fixes #29787

(cherry picked from commit 911a58c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug linear algebra Linear algebra sparse Sparse arrays stdlib Julia's standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug in QRsparse
3 participants
@andreasnoack @fredrikekre @KristofferC