interpreter: fix pref regression from #29795 #29873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
|
Not quite the right comparison (since it used the merge commit on master), but does conform there are no regressions with this fixed. |
tkf
pushed a commit
to tkf/julia
that referenced
this pull request
Nov 21, 2018
KristofferC
pushed a commit
that referenced
this pull request
Nov 28, 2018
KristofferC
pushed a commit
that referenced
this pull request
Dec 12, 2018
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #29872
Silly me used the wrong variable / copied the code from the wrong place, and accidentally disabled inference of the wrong subgraph.