Define typemin/typemax for BigInt #29815
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be nice to have
typemin
/typemax
defined for allInteger
subtypes. I don't think it unreasonable to say that any custom type which is a subtype ofInteger
should have these methods defined for that type.This concept was thought of this while working on speeding up some generic code in FixedPointDecimals which used
typemax
onInteger
types. While creating this PR I discoveredhastypemax
which works but I think it should be eventually be deprecated as theapplicable(typemax, T)
fallback is not very performant for custom types.