Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SYSTEMROOT env variable for powershell detection #29803

Merged
merged 3 commits into from
Nov 7, 2018
Merged

Use SYSTEMROOT env variable for powershell detection #29803

merged 3 commits into from
Nov 7, 2018

Conversation

musm
Copy link
Contributor

@musm musm commented Oct 25, 2018

fix #29802

vtjnash
vtjnash reviewed Oct 25, 2018
View reviewed changes
base/download.jl Outdated Show resolved Hide resolved
@musm musm changed the title Use WINDIR env variable for download function Use SYSTEMROOT env variable for powershell detection Oct 26, 2018
musm
musm commented Oct 26, 2018
View reviewed changes
base/download.jl Show resolved Hide resolved
@musm
Copy link
Contributor Author

musm commented Oct 31, 2018

bump

@StefanKarpinski
Copy link
Member

@vtjnash: this has been updated—if it looks good to you now, merge?

@musm
Copy link
Contributor Author

musm commented Nov 2, 2018

Yes I updated with @vtjnash suggestion. Its good to merge and backport.

@musm
Copy link
Contributor Author

musm commented Nov 7, 2018

also @staticfloat (same change as in binarybuilder)

@fredrikekre fredrikekre merged commit 7454dc9 into JuliaLang:master Nov 7, 2018
@musm musm deleted the patch-10 branch November 7, 2018 16:34
@musm
Copy link
Contributor Author

musm commented Nov 7, 2018

thanks for the approve and merge. Can we add a backport label here too?

@musm
Copy link
Contributor Author

musm commented Nov 12, 2018

@KristofferC this is a backport eligible PR

KristofferC pushed a commit that referenced this pull request Nov 19, 2018
@musm @KristofferC
Use SYSTEMROOT env variable for powershell detection (#29803)
2d4ef03 
(cherry picked from commit 7454dc9)
@KristofferC KristofferC mentioned this pull request Nov 19, 2018
Merged
61 tasks
tkf pushed a commit to tkf/julia that referenced this pull request Nov 21, 2018
@musm @tkf
Use SYSTEMROOT env variable for powershell detection (JuliaLang#29803)
cd17533
KristofferC pushed a commit that referenced this pull request Dec 12, 2018
@musm @KristofferC
Use SYSTEMROOT env variable for powershell detection (#29803)
441a887 
(cherry picked from commit 7454dc9)
@KristofferC KristofferC added bugfix This change fixes an existing bug and removed backport pending 1.0 labels Dec 12, 2018
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@musm @KristofferC
Use SYSTEMROOT env variable for powershell detection (#29803)
3b160d5 
(cherry picked from commit 7454dc9)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@musm @KristofferC
Use SYSTEMROOT env variable for powershell detection (#29803)
8f472dc 
(cherry picked from commit 7454dc9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan left review comments

@vtjnash vtjnash vtjnash left review comments

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hard-coded path in Base.download to PowerShell may fail
7 participants
@musm @StefanKarpinski @staticfloat @vtjnash @nalimilan @KristofferC @fredrikekre