fixes for the runtime (interpreted intrinsics) #29721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Oct 19, 2018
vtjnash
force-pushed
the
jn/interpret-intrinsics
branch
from
8b98cd7 to
27bbb8a
Compare
Handle case where runtime_nbits is not a power of two, and be more careful to avoid C compiler undefined behavior and tricky promotion rules when defining these.
previously, we only handled the case where it was implicitly null
vtjnash
force-pushed
the
jn/interpret-intrinsics
branch
from
27bbb8a to
386a8c2
Compare
|
Does that mean that all tests pass in the interpreter now? |
|
Does not backport cleanly. Please push backport to "backport-1.0.3" or make a rebased branch on top of that and I will backport the commits. @vtjnash |
StefanKarpinski
added
triage
|
Doesn't seem the backport will happen. |
KristofferC
removed
backport 1.0
triage
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #29379