Make package files read-only for Pkg.add #29439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please reopen this towards the Pkg.jl repo. We try to keep all Pkg development there for more focused discussion. |
bors bot
added a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Oct 1, 2018
785: Make package files read-only for Pkg.add r=KristofferC a=timholy Closes #32. Test fail for me locally with a JSON error, but hopefully that's just because an existing JSON installation or something. Tests passed at JuliaLang/julia#29439, for whatever that is worth. Error: ```julia ERROR: LoadError: LoadError: LoadError: Unsatisfiable requirements detected for package JSON [682c06a0]: JSON [682c06a0] log: ├─possible versions are: [0.1.0-0.1.1, 0.2.0-0.2.4, 0.3.0-0.3.9, 0.4.0-0.4.6, 0.5.0-0.5.4, 0.6.0-0.6.1, 0.7.0-0.7.1, 0.8.0-0.8.3, 0.9.0-0.9.1, 0.10.0, 0.11.0, 0.12.0, 0.13.0, 0.14.0, 0.15.0-0.15.2, 0.16.0-0.16.4, 0.17.1-0.17.2, 0.18.0, 0.19.0] or uninstalled ├─restricted to versions 0.16.0-0.16 by an explicit requirement, leaving only versions 0.16.0-0.16.4 └─restricted by julia compatibility requirements to versions: [0.18.0, 0.19.0] or uninstalled — no versions left ``` Co-authored-by: Tim Holy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes JuliaLang/Pkg.jl#32
I wanted to get started on timholy/Revise.jl#146 but I think doing this first is basically a prerequisite to any kind of sensible implementation.