Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This comma confused me. Remove it #29099

Merged
merged 1 commit into from
Sep 9, 2018
Merged

This comma confused me. Remove it #29099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/src/manual/integers-and-floating-point-numbers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ of the binary data item is the minimal needed size, if the leading digit of the
`0`. In the case of leading zeros, the size is determined by the minimal needed size for a
literal, which has the same length but leading digit `1`. That allows the user to control
the size.
Values, which cannot be stored in `UInt128` cannot be written as such literals.
Values which cannot be stored in `UInt128` cannot be written as such literals.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a native English speaker, but shouldn't a subclause that is essential (which is why the comma is not at its place), use "that" instead of "which", i.e. either of the following would be grammatically correct, but the latter does of course not have the correct meaning:

Values that cannot be stored in UInt128 cannot be written as such literals.

Values, which cannot be stored in UInt128, cannot be written as such literals.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lose the double negative:
"Only values that can be stored in UInt128 can be written as such literals."

Binary, octal, and hexadecimal literals may be signed by a `-` immediately preceding the
unsigned literal. They produce an unsigned integer of the same size as the unsigned literal
Expand Down