Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup history file for generate_precompile #29068

Merged
merged 1 commit into from
Oct 6, 2018

Conversation

iblislin
Copy link
Member

@iblislin iblislin commented Sep 6, 2018

No description provided.

@@ -84,7 +84,8 @@ function generate_precompile_statements()
slave, master = open_fake_pty()
end
done = false
withenv("JULIA_HISTORY" => tempname(), "JULIA_PROJECT" => nothing,
blackhole = Sys.isunix() ? "/dev/null" : "nul"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice variable name

@ararslan ararslan requested a review from KristofferC September 7, 2018 19:36
@iblislin
Copy link
Member Author

iblislin commented Oct 3, 2018

ping @KristofferC

@KristofferC
Copy link
Member

👍 let's restart CI and merge

@KristofferC KristofferC closed this Oct 3, 2018
@KristofferC KristofferC reopened this Oct 3, 2018
@ararslan ararslan merged commit cfc967b into JuliaLang:master Oct 6, 2018
@iblislin iblislin deleted the ib/gen-precompile-clean branch October 6, 2018 14:50
KristofferC pushed a commit that referenced this pull request Oct 6, 2018
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants