Add julia line to compat example #28947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `julia = "1.0"` to compat example in Compatibility section. Since julia is not a package, it's not obvious this is the place to put this, so adding the explicit example is helpful.
StefanKarpinski
approved these changes
Aug 29, 2018
|
Yes (I think I have a branch somewhere that does this so it is indeed something that we should do). But can you please open this change against the https://github.com/JuliaLang/Pkg.jl repo. We try to make all changes to Pkg there now. |
mcmcgrath13
added a commit
to mcmcgrath13/Pkg.jl
that referenced
this pull request
Sep 4, 2018
Adding this PR here instead of [JuliaLang](JuliaLang/julia#28947) per @KristofferC
|
Sounds good! Opened the PR |
bors bot
added a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Sep 17, 2018
702: add support for "ssh" protocol r=KristofferC a=Evizero
This is a minimalistic change to support the use of `Pkg.setprotocol!("ssh")` to fix #653.
My naive reasoning here is that since "github" is hardcoded anyway, one might as well adapt the URL string for when using the ~~"git"~~ "ssh" protocol.
Note though that this only works if the repo has not been cloned into ".julia/clones" already using the defaul setting (i.e. https). If that is the case then `dev Example` will say
```
Updating git-repo `[email protected]:JuliaLang/Example.jl.git`
```
while `git remote -v` in that new dev-ed directory will still show `origin` using the `https` version.
Not sure where to fix that.
716: Update project.toml compat example r=KristofferC a=mcmcgrath13
Adding this PR here instead of [JuliaLang](JuliaLang/julia#28947) per @KristofferC
Co-authored-by: Christof Stocker <[email protected]>
Co-authored-by: Mary McGrath <[email protected]>
KristofferC
pushed a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Sep 18, 2018
Adding this PR here instead of [JuliaLang](JuliaLang/julia#28947) per @KristofferC (cherry picked from commit 9673615)
KristofferC
pushed a commit
that referenced
this pull request
Sep 18, 2018
Adding this PR here instead of [JuliaLang](#28947) per @KristofferC (cherry picked from commit 96736153524144d83e9d6458feae7a39be7d1b7d) (cherry picked from commit ac5965bf9a8a5b4de535e3b3e2bc4668719fd51b)
KristofferC
pushed a commit
that referenced
this pull request
Sep 19, 2018
Adding this PR here instead of [JuliaLang](#28947) per @KristofferC (cherry picked from commit 96736153524144d83e9d6458feae7a39be7d1b7d) (cherry picked from commit ac5965bf9a8a5b4de535e3b3e2bc4668719fd51b) (cherry picked from commit 4a72ad4)
KristofferC
pushed a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Oct 1, 2018
Adding this PR here instead of [JuliaLang](JuliaLang/julia#28947) per @KristofferC (cherry picked from commit 9673615)
fredrikekre
pushed a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Oct 15, 2018
Adding this PR here instead of [JuliaLang](JuliaLang/julia#28947) per @KristofferC (cherry picked from commit 9673615) (cherry picked from commit ac5965b)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
Adding this PR here instead of [JuliaLang](#28947) per @KristofferC (cherry picked from commit 96736153524144d83e9d6458feae7a39be7d1b7d) (cherry picked from commit ac5965bf9a8a5b4de535e3b3e2bc4668719fd51b) (cherry picked from commit 4a72ad4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
julia = "1.0"to compat example in Compatibility section. Since julia is not a package, it's not obvious this is the place to put this, so adding the explicit example is helpful.